Skip to content

unset.possiblyHookedProperty is reported for properties annotated @final #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 14, 2025
Merged

unset.possiblyHookedProperty is reported for properties annotated @final #3990

merged 8 commits into from
May 14, 2025

Conversation

lpd-au
Copy link
Contributor

@lpd-au lpd-au commented May 13, 2025 •
edited
Loading

@lpd-au lpd-au marked this pull request as ready for review May 13, 2025 14:24
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes
Copy link
Member

For classes there's isFinal and isFinalByKeyword. I'd like to follow the same convention here.

Also, there should be a new test for OverridingPropertyRule checking when a @final property is overriden. Also, OverridingMethodRule changes the error message and identifier based on whether it's final or @final so I'd like for OverridingPropertyRule to do the same.

Thanks.

ondrejmirtes
ondrejmirtes requested changes May 13, 2025
View reviewed changes
lpd-au
lpd-au commented May 14, 2025
View reviewed changes
src/Reflection/WrappedExtendedPropertyReflection.php

public function isFinal(): TrinaryLogic
{
return TrinaryLogic::createNo();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what this class represents, hope it's okay

@lpd-au lpd-au requested a review from ondrejmirtes May 14, 2025 12:19
ondrejmirtes
ondrejmirtes requested changes May 14, 2025
View reviewed changes
@lpd-au lpd-au requested a review from ondrejmirtes May 14, 2025 12:58
@ondrejmirtes
Copy link
Member

Thank you!

@ondrejmirtes ondrejmirtes merged commit 2fb3dbe into phpstan:2.1.x May 14, 2025
410 of 416 checks passed
@lpd-au lpd-au deleted the issue-12999 branch May 14, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unset.possiblyHookedProperty is reported for properties annotated @final

3 participants

@lpd-au @phpstan-bot @ondrejmirtes